-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position Override created to allow position testing #2263
Conversation
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
soccer/src/soccer/strategy/agent/position/robot_factory_position.hpp
Outdated
Show resolved
Hide resolved
automated style fixes Co-authored-by: jvogt23 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work!
soccer/src/soccer/strategy/agent/position/overriding_positions.hpp
Outdated
Show resolved
Hide resolved
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
automated style fixes Co-authored-by: jvogt23 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. the main thing i'd want to discuss is the choice of topics. everything else was just me being nitpicky, feel free to ignore
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
…on.cpp Co-authored-by: Siddharth Parikh <[email protected]>
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
Thanks for making that change. I'm real excited for this feature. just a minor nitpick. also @shourikb @jacksherling has someone tested this? i only reviewed code |
Description
Describe your pull request.
Created a way to override a robot's current position for testing purposes.
Associated / Resolved Issue
Resolves # or ClickUp card
Design Documents
Link
Steps to Test
Test Case 1
Expected result:???
Key Files to Review
Group 1 - namespace strategy
Group 2 - UI
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.