Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot Factory Upgrade #2338

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Robot Factory Upgrade #2338

merged 2 commits into from
Feb 12, 2025

Conversation

rishiso
Copy link
Contributor

@rishiso rishiso commented Feb 3, 2025

Description

  • Changed robot factory to always use SmartIdle instead of Idle
  • Reenabled dynamic position assignment
  • Switched SoloOffense to Offense

Associated / Resolved Issue

Resolves ClickUp card

Steps to Test

Dynamic position assignment

Move ball from their half to our half and vice versa -> robot positions should change

Idling and offense change

Trust

automated style fixes

Co-authored-by: rishiso <[email protected]>
Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sanatd33 sanatd33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire

@rishiso rishiso merged commit 9d0d4d1 into ros2 Feb 12, 2025
2 checks passed
@rishiso rishiso deleted the robot-factory-upgrade branch February 12, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants