Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Jazzy distribution #68

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

f0reachARR
Copy link

In this PR, I will introduce a support for Jazzy distribution. (Iron is not tested but I think it will work)

There are some changes:

  • Add repository information for Jazzy, including new package rosidl_core.
  • Changes for CMake functions
    • Use more proper way (checking dependencies version) to use rosidl_get_typesupport_target
    • Add jazzy as CycloneDDS supported distribution.

I tested this PR on my Ubuntu 24.04 + Unity 2022.3.15f1 + ROS 2 Jazzy environment.

@LegitYew0108
Copy link

I tested this PR on Ubuntu24.04 + ROS 2 Jazzy environment, but I encountered one error with --standalone option.

CMake Error at CMakeLists.txt:294 (message):
  Could not find yaml
Call Stack (most recent call first):
  CMakeLists.txt:395 (get_standalone_dependencies)

So, I changed these points, and it works successfully.

(src/ros2cs/ros2cs_core/CMakeLists.txt)

(row:31)
+ find_package( yaml-cpp REQUIRED)
....
(row:360~382)
  set(ros2_standalone_libs

    rcl
    rcl_logging_spdlog
    rcl_yaml_param_parser
    rcpputils
    rcutils
    rmw
    FastRTPS
    rmw_fastrtps_cpp
    CycloneDDS
    rmw_cyclonedds_cpp
    rmw_dds_common
    rmw_implementation
    rosidl_runtime_c
    rosidl_typesupport_c
    rosidl_typesupport_cpp
    rosidl_typesupport_introspection_c
    rosidl_typesupport_introspection_cpp
    spdlog
    tracetools
-   yaml
+   yaml-cpp
    tinyxml2
  )

@f0reachARR
Copy link
Author

Thank you @LegitYew0108 ! I confirmed yaml-cpp errors on standalone mode, and fixed it.

@watanabe-pfr
Copy link

watanabe-pfr commented Jan 15, 2025

Thank you for your work, I would like the maintainer to merge this PR.

I've also tested this branch with Ros2ForUnity, and it works with my Jazzy environment (Ubuntu 24.04, ROS 2 Jazzy)

Maybe the line of find_package is needed as @LegitYew0108 mentioned.

+ find_package(yaml-cpp REQUIRED)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants