-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RAC Style Library into Aurora #683
Conversation
…otals from titles
Changes implemented after usability testing:
@helrond would you mind reviewing my last two commits related to allowing donor users to see the Saved Accessions to make sure I didn't miss anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
fix #555
fix #658
fix #646
fix #664
fix #668
fix #700
Implements the RAC Style Library into Aurora including substantial UI redesign and app updates.
machine_file_upload_time
data is already defined via models and views in the format we display it in, so unless I'm missing something we don't need to define a date format in the templates).delete_object_js
script for Bagit and Rights org tables so that "there are no existing..." paragraph appears when table is deleted.Style Library updates
See styles repo PR 235 for associated updates made to style library based on its implementation in Aurora.
Other considerations
We have implemented Datatables serverside in Aurora. If we anticipate 1000s of rows of data (which we may, over time!) this makes sense. Otherwise, I'm not sure we need that and it could make maintaining local Datatables functionality easier to use a client side implementation. I haven't changed the implementation here, though. Could be worth revisiting as part of issue #646 .