-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TelegramBots platform #523
base: master
Are you sure you want to change the base?
Conversation
The build is successful btw, tests failed because of ProtocolLib what is unrelated |
@@ -32,7 +32,7 @@ If you don’t update, **permissions will default to OR behavior** in the new ve | |||
[](https://www.java.com/) | |||
|
|||
### LiteCommands | |||
Annotation based command framework for Velocity, Bukkit, Paper, BungeeCord, Minestom, Sponge, Fabric, JDA and future implementations. | |||
Annotation based command framework for Velocity, Bukkit, Paper, BungeeCord, Minestom, Sponge, Fabric, JDA, TelegramBots and future implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make it a bullet list now 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bullet list below already, I guess we shouldn't make a second one
...ommands-telegrambots/src/dev/rollczi/litecommands/telegrambots/LiteTelegramBotsSettings.java
Outdated
Show resolved
Hide resolved
…mbots/LiteTelegramBotsSettings.java Co-authored-by: Jakub Kędziora <[email protected]>
I need some thoughts and help about the "problems I see" section since I cannot solve it by myself |
Hi there!
I implemented a basic support for TelegramBots (Telegram-recommended Java library). It's kinda finished in the current state, but, due to how different it is from more common platforms like Bukkit, there are some pitfalls.
Firstly, we have some limitations here:
BiPredicate
in the settings of that platform, so the library user can implement it manually (it's a common thing for Telegram to have admin commands I believe).My suggested setup:
Problems I see:
false
currently.Update
,Message
objects to the command handles and result handlers somehow. Otherwise the library user might not be able to send messages etc.