Skip to content

Keep BoxedMontyParams in an Arc#808

Merged
tarcieri merged 2 commits into
RustCrypto:masterfrom
fjarri:params-arc
Apr 24, 2025
Merged

Keep BoxedMontyParams in an Arc#808
tarcieri merged 2 commits into
RustCrypto:masterfrom
fjarri:params-arc

Conversation

@fjarri
Copy link
Copy Markdown
Contributor

@fjarri fjarri commented Apr 24, 2025

Fixes #804

Deref impl leaks the inner type. Should I make the conversion explicit instead?

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Apr 24, 2025

Yeah, maybe instead of Deref just add explicit methods which delegate to the inner type?

@tarcieri tarcieri merged commit 3f21087 into RustCrypto:master Apr 24, 2025
18 checks passed
@fjarri fjarri deleted the params-arc branch April 24, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Arc inside BoxedMontyParams?

2 participants