Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aead: factor apart AeadInPlace/*Detached #1714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarcieri
Copy link
Member

Factors apart the detached methods of AeadInPlace into a separate AeadInPlaceDetached trait, which itself can now more easily be further refactored (by adding e.g. inout support).

Also adds a PostfixTagged trait which is used to gate the blanket impls.

@tarcieri
Copy link
Member Author

This is the local WIP I was working on to address some of the concerns in #1672 which I mentioned in #1713. It's nowhere close to complete, but I thought I'd push it up for comparison.

@tarcieri tarcieri mentioned this pull request Nov 16, 2024
Factors apart the detached methods of `AeadInPlace` into a separate
`AeadInPlaceDetached` trait, which itself can now more easily be further
refactored (by adding e.g. `inout` support).

Also adds a `PostfixTagged` trait which is used to gate the blanket
impls.
@tarcieri tarcieri force-pushed the aead/factor-apart-aead-in-place branch from af2c258 to d60f55e Compare February 23, 2025 10:37
@tarcieri tarcieri changed the title [WIP] aead: factor apart AeadInPlace/*Detached aead: factor apart AeadInPlace/*Detached Feb 23, 2025
@tarcieri tarcieri marked this pull request as ready for review February 23, 2025 10:42
@tarcieri
Copy link
Member Author

I wrote this as a stepstone to inout support, with the idea being to replace AeadInPlaceDetached with an AeadInOut trait or thereabouts.

It's a self-contained step in that direction though which is independently useful, however I can open a separate PR that goes to inout support directly (which is really just replacing the input slice with InOutBuf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant