Webpage to display a set of benchmarks from RustPython #43
Conversation
The page looks for images in a folder to display these
_config.yml
Outdated
| @@ -36,6 +36,8 @@ navigation: | |||
| url: /blog | |||
| - title: Docs | |||
| url: /docs | |||
| - title: Benchmarks | |||
| url: /benchmarks | |||
There was a problem hiding this comment.
I think we should hold off on adding this to the main menu.
The main menu should have something like "dashboards", then under it a drop-down where we can list benchmarks, cpython compatibility, what is left (and maybe others).
There was a problem hiding this comment.
I agree with this, I will edit it. But before I do, I have a question about this:
To what should the "CPython compatibility" and "What's left" options link to?
There was a problem hiding this comment.
@mireille-raad I have moved the link to the benchmarks page to the dashboard for now and removed it from the navbar. Let me know if this is good enough or whether you still want to have a dropdown menu added to the navbar for the dasboard.
Better function decleration Co-authored-by: Niels Bauman <[email protected]>
Better function decleration Co-authored-by: Niels Bauman <[email protected]>
Using const for objects Co-authored-by: Niels Bauman <[email protected]>
Using const for objects Co-authored-by: Niels Bauman <[email protected]>
|
This PR from the RustPython repo has just been merged! This means that the benchmarks webpage would now be able to display the benchmarks that are being saved to this repo. |
|
I think this code looks great and is ready to be merged as well. Thank you so much! I saw that the Pull Request that generates the benchmarks just got merged. The GitHub action needs time to run since it is a cron job. Let's wait for the first batch of benchmarks to be udpated here and then we merge this (otherwise there will be the error message) |
|
Yup, I think it should run this evening, 0000 UTC Saturday |
|
I saw that @coolreader18 and @nielsbauman added the data manually. Should we merge this for now? |
I think we can merge this now 👍 |
This PR addresses #42 and thereby also the final part of this issue (2396) from the RustPython repo.
If this PR from the RustPython repo is merged, this PR can display the benchmarks that are being saved to this repo.
Here is an example of how the webpage would look like (given that a set of benchmarks have been committed to this repo)
And here an example of the webpage given that the set of benchmarks are not available
The code basically checks if the /assets/criterion/ folder exists and this folder should contain sub-folders with each set of benchmarks. The tabs are programmatically generated from the sub-folder names and the set of benchmarks in these sub-folders form the content of each tab.