Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new icon for resampling #621

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: new icon for resampling #621

wants to merge 2 commits into from

Conversation

johannes-kolbe
Copy link
Contributor

Issue

#615

Description

Adds new icon to resolve resampling issue

Checklist for Pull Requests

  • Supplied as many details as possible on this change
  • Included the link to the associated issue in the Issue section above
  • The code conforms to the general development guidelines.
  • The code has unit tests where applicable and is easily unit-testable
  • This branch is appropriately named for the associated issue

@johannes-kolbe johannes-kolbe requested a review from a team as a code owner February 27, 2025 10:09
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 7f08ffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
sap-guided-answers-extension Patch
@sap/guided-answers-extension-core Patch
@sap/guided-answers-extension-types Patch
@sap/guided-answers-extension-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hitesh-parmar hitesh-parmar self-requested a review February 27, 2025 11:20
@gpeuc
Copy link
Contributor

gpeuc commented Feb 27, 2025

@johannes-kolbe - do these look better?

Copy link
Contributor

@hitesh-parmar hitesh-parmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, file name of the icon needs renaming to include @2x.png

Copy link
Contributor

@hitesh-parmar hitesh-parmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpeuc I see that GitHub is marking the file as 552 x 552, shouldn't it be 512x 512 ?

image

@gpeuc
Copy link
Contributor

gpeuc commented Feb 27, 2025

@johannes-kolbe said he'd use 512 ones. But it doesn't matter much. 552 ones have 512px just for the icon, but then the shadow bleeds out making it 552 😄, and 512 ones have shadow and icon packed up into 512. Ultimately, I don't think it matters that much, unless we are OCD and really want 512.

Screenshot 2025-02-27 at 19 53 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants