-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: new icon for resampling #621
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7f08ffc The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@johannes-kolbe - do these look better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, file name of the icon needs renaming to include @2x.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpeuc I see that GitHub is marking the file as 552 x 552, shouldn't it be 512x 512 ?
@johannes-kolbe said he'd use 512 ones. But it doesn't matter much. 552 ones have 512px just for the icon, but then the shadow bleeds out making it 552 😄, and 512 ones have shadow and icon packed up into 512. Ultimately, I don't think it matters that much, unless we are OCD and really want 512. ![]() |
Issue
#615
Description
Adds new icon to resolve resampling issue
Checklist for Pull Requests