feat: add values for dnsPolicy and hostNetwork #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sanadhis
force-pushed
the
feat-dns-policy-host-network
branch
from
d457b91 to
b703d2f
Compare
|
assign @cbarbian-sap @zdenko-kovac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
When deploying webhook to the EKS cluster with custom CNI plugin such as Calico, Weave, and so on.
hostNetworkmust be set to true due EKS api cannot access the pod networkRef:
aws/containers-roadmap#1215
aws/karpenter-provider-aws#1602
Solution
Let's set the possibility to modify
dnsPolicyandhostNetworkto support this use-case.The idea is to set default value to the default from k8s so this feature won't introduce regression.
assign @cbarbian-sap @zdenko-kovac