fix(cf-deploy-config-writer): fix lint

SAP · Jan 23, 2025 · 808ffd3 · 808ffd3
1 parent 740f4e8
commit 808ffd3
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 14 deletions.
diff --git a/packages/cf-deploy-config-writer/src/cf-writer/app-config.ts b/packages/cf-deploy-config-writer/src/cf-writer/app-config.ts
@@ -51,14 +51,8 @@ import {
 import LoggerHelper from '../logger-helper';
 import { t } from '../i18n';
 import { type Logger } from '@sap-ux/logger';
-import {
-    ApiHubType,
-    type CFAppConfig,
-    type CFConfig,
-    type MTABaseConfig,
-    RouterModuleType,
-    XSAppDocument
-} from '../types';
+import type { XSAppDocument } from '../types';
+import { ApiHubType, type CFAppConfig, type CFConfig, type MTABaseConfig } from '../types';
 
 /**
  * Add a managed approuter configuration to an existing HTML5 application.
@@ -259,8 +253,9 @@ export function generateMTAFile(cfConfig: CFConfig): void {
 
 /**
  * Updates the MTA configuration file.
- * @param fs reference to a mem-fs editor
+ *
  * @param cfConfig writer configuration
+ * @param fs reference to a mem-fs editor
  */
 async function updateMtaConfig(cfConfig: CFConfig, fs: Editor): Promise<void> {
     const mtaInstance = await getMtaConfig(cfConfig.rootPath);

diff --git a/packages/cf-deploy-config-writer/src/cf-writer/base-config.ts b/packages/cf-deploy-config-writer/src/cf-writer/base-config.ts
@@ -1,6 +1,6 @@
 import { create as createStorage } from 'mem-fs';
 import { create, type Editor } from 'mem-fs-editor';
-import { addSupportingConfig, addRoutingConfig, setMtaDefaults } from '../utils';
+import { addSupportingConfig, addRoutingConfig } from '../utils';
 import LoggerHelper from '../logger-helper';
 import { createMTA, validateMtaConfig } from '../mta-config';
 import { type Logger } from '@sap-ux/logger';

diff --git a/packages/cf-deploy-config-writer/src/cf-writer/cap-config.ts b/packages/cf-deploy-config-writer/src/cf-writer/cap-config.ts
@@ -1,7 +1,7 @@
 import { create as createStorage } from 'mem-fs';
 import { create, type Editor } from 'mem-fs-editor';
-import { addSupportingConfig, addRoutingConfig, setMtaDefaults } from '../utils';
-import { createCAPMTA, doesMTABinaryExist, validateMtaConfig } from '../mta-config';
+import { addSupportingConfig, addRoutingConfig } from '../utils';
+import { createCAPMTA, validateMtaConfig } from '../mta-config';
 import LoggerHelper from '../logger-helper';
 import type { Logger } from '@sap-ux/logger';
 import type { CAPConfig, CFBaseConfig } from '../types';

diff --git a/packages/cf-deploy-config-writer/src/mta-config/index.ts b/packages/cf-deploy-config-writer/src/mta-config/index.ts
@@ -120,15 +120,25 @@ export function doesCDSBinaryExist(): void {
     }
 }
 
+/**
+ *
+ * @param cwd
+ * @param options
+ */
 export function addCAMtaServices(cwd: string, options?: string[]): void {
-    let result = spawnSync(CDSExecutable, [...CDSAddMtaParams, ...(options ?? [])], { cwd });
+    const result = spawnSync(CDSExecutable, [...CDSAddMtaParams, ...(options ?? [])], { cwd });
     if (result.error) {
         throw new Error(CDSBinNotFound);
     }
 }
 
+/**
+ *
+ * @param cwd
+ * @param options
+ */
 export function createCAPMTA(cwd: string, options?: string[]): void {
-    let result = spawnSync(CDSExecutable, [...CDSAddMtaParams, ...(options ?? [])], { cwd });
+    const result = spawnSync(CDSExecutable, [...CDSAddMtaParams, ...(options ?? [])], { cwd });
     if (result.error) {
         throw new Error(CDSBinNotFound);
     }

diff --git a/packages/cf-deploy-config-writer/src/mta-config/mta.ts b/packages/cf-deploy-config-writer/src/mta-config/mta.ts
@@ -206,6 +206,11 @@ export class MtaConfig {
         this.dirty = true;
     }
 
+    /**
+     *
+     * @param serviceName
+     * @param resourceName
+     */
     private async updateServiceName(serviceName: string, resourceName: string): Promise<void> {
         const resource = this.resources.get(resourceName);
         if (resource && !resource.parameters?.['service-name']) {