Skip to content

Commit

Permalink
fix(axios-extension): log the level set by the response node (#1048)
Browse files Browse the repository at this point in the history
  • Loading branch information
longieirl authored May 31, 2023
1 parent 50d1d36 commit aeb4cd8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/new-crabs-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sap-ux/axios-extension': patch
---

handle entry severity in logging
2 changes: 1 addition & 1 deletion packages/axios-extension/src/abap/message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export function prettyPrintMessage({ msg, log, host }: { msg: string; log: Logge
logFullURL({ host, path: jsonMsg['longtext_url'], log });
if (jsonMsg.details) {
jsonMsg.details.forEach((entry) => {
log.info(entry.message);
logLevel(entry.severity, entry.message, log);
});
}
} catch (error) {
Expand Down
6 changes: 4 additions & 2 deletions packages/axios-extension/test/abap/message.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@ describe('message helpers', () => {
longtext_url: '/abc/de',
details: [
{ code: '1', message: '~message', severity: 'info' },
{ code: '2', message: '~message', severity: 'info' }
{ code: '2', message: '~message', severity: 'warning' }
]
};

const infoMock = (log.info = jest.fn());
const warningMock = (log.warn = jest.fn());
prettyPrintMessage({ msg: JSON.stringify(msg), log, host });
// log main message, two messages for the full url, and each detail
expect(infoMock).toBeCalledTimes(1 + 2 + msg.details.length);
expect(infoMock).toBeCalledTimes(4);
expect(warningMock).toBeCalledTimes(1);
});

test('log none JSON message for debugging', () => {
Expand Down

0 comments on commit aeb4cd8

Please sign in to comment.