feat: Multiple service support #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd2d06e The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broksy
added
mockserver-config-writer
johannes-kolbe
previously approved these changes
Nov 29, 2024
heimwege
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Mainly found some hard coded webapp paths that should be replaced by getWebappPath from project-access
packages/mockserver-config-writer/src/mockserver-config/ui5-mock-yaml.ts
Outdated
Show resolved
Hide resolved
packages/mockserver-config-writer/src/mockserver-config/ui5-mock-yaml.ts
Outdated
Show resolved
Hide resolved
packages/mockserver-config-writer/src/mockserver-config/ui5-mock-yaml.ts
Outdated
Show resolved
Hide resolved
heimwege
previously approved these changes
Nov 29, 2024
broksy
dismissed
tobiasqueck’s stale review
Already reviewed by Dominik and Johannes.
tobiasqueck
reviewed
Dec 2, 2024
tobiasqueck
reviewed
Dec 2, 2024
tobiasqueck
reviewed
Dec 2, 2024
tobiasqueck
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Added a few comments for improvement, otherwise, the coding adheres to expectations. However, my local tests fail. @broksy I will send you an internal project that gets misconfigured when adding a mockserver config.
tobiasqueck
approved these changes
Dec 2, 2024
johannes-kolbe
approved these changes
Dec 2, 2024
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple services and multiple annotations per service. Includes updates for multiple packages.
odata-service-writer
remove(basePath, service, fs?)to handle service related data removal from manifest.json and YAML filesgenerateMockserverConfig: overwrite (if true, then mockserver services and annotations are overwritten based on manifest dataSources), else dataSources for services and annotations from manifest are collected and appended to the existing mockserver dataenhanceDatafunction updated with default service name and annotation name handling.mainServicewill be used as the default name for first service,_Annotationwill be added to annotation name if annotation name matches service name to avoid generation of duplications in manifestdataSourcessection.mockserver-config-writer
removeMockDataFolders(fs, basePath)to remove all mock data paths during running ofremoveMockserverConfig.ui5-config
addServiceToMockserverMiddleware(dataSourceConfig, appRoot?, annotationsConfig = [])to add service to mockserver using information from manifest dataSourceremoveServiceFromMockServerMiddleware(servicePath, annotationsPaths)to delete service from mockserver including annotations related to this service using information from manifest dataSourceaddBackendToFioriToolsProxydMiddleware(backend)to handle multiple backends and avoid duplicatesremoveBackendFromFioriToolsProxydMiddleware(backendUrl)to delete backend from fiori-tools-proxy usingcreate
fiori-freestyle-writer
'/'(Unix like separator) tosep(universal separator) frompathmodule during template generation inprocessDestinationPath(filePath)in order to make replace work also on Windows like paths.