Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Service update support #2904

Merged
merged 18 commits into from
Feb 14, 2025
Merged

feat: Service update support #2904

merged 18 commits into from
Feb 14, 2025

Conversation

broksy
Copy link
Contributor

@broksy broksy commented Feb 11, 2025

Currently only generate and remove functions are supported.
Adds additional update function to odata-service-writer to support service updates.

Features:

  • Added update function for service related data updates (manifest.json dataSources, annotation files, changes in YAML files),
  • In case of service update, package.json will not be updated,
  • In case of service update, annotations files will be removed and rewritten (remote annotations could have changed for the service).
  • Mockserver configuration during update will only be added if ui5-mock.yaml already exists,
  • Missing unit test checks for remove to check if remote annotation files are removed.

@broksy broksy added the odata-service-writer @sap-ux/odata-servier-writer label Feb 11, 2025
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: dc0e52b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@sap-ux/mockserver-config-writer Minor
@sap-ux/odata-service-writer Minor
@sap-ux/create Patch
@sap-ux/adp-tooling Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@broksy broksy changed the title feat: Update service feat: Service update support Feb 12, 2025
@broksy broksy marked this pull request as ready for review February 12, 2025 22:27
@broksy broksy requested review from a team as code owners February 12, 2025 22:27
johannes-kolbe
johannes-kolbe previously approved these changes Feb 13, 2025
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes and refactorings lg
  • Unit tests provided
  • Fokus on new update function and tools-suite consumption
  • Changeset provided

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Snapshot updates are only json ordering so ok.
changeset ✅
Checked with service modeler and working well for legacy projects using UI5 mockserver in browser.

Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

@PetrStribrny
Copy link
Member

ux-tools-mockserver-config-writer reviwers asked for review

Copy link
Member

@unseen1980 unseen1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments that can be fixed in a following PR. Thanks

@broksy
Copy link
Contributor Author

broksy commented Feb 14, 2025

Some small comments that can be fixed in a following PR. Thanks

I will create a separate pull requests with those change requests.

@broksy broksy merged commit f1f9cbe into main Feb 14, 2025
16 checks passed
@broksy broksy deleted the fix/serviceUpdates branch February 14, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odata-service-writer @sap-ux/odata-servier-writer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants