Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] generateThemeDesignerResources: Allow core .theming in sources #1066

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 22, 2024

This change respects an sap.ui.core library .theming file from the sources instead of simply overwriting the file.
It allows the configuration to be put into the library and adjusted there instead of having to adjust it in the build task.

The existing logic is kept to support older UI5 versions where the file is not available in the sources.

JIRA: CPOUI5FOUNDATION-862
(cherry picked from commit dda3011)

…rces

This change respects an sap.ui.core library .theming file from the
sources instead of simply overwriting the file.
It allows the configuration to be put into the library and adjusted
there instead of having to adjust it in the build task.

The existing logic is kept to support older UI5 versions where the file
is not available in the sources.

JIRA: CPOUI5FOUNDATION-862
(cherry picked from commit dda3011)
@matz3 matz3 force-pushed the fix-dot-theming branch from 70a646c to 382f10a Compare July 22, 2024 15:53
@matz3 matz3 changed the title [FIX] generateThemeDesignerResources: Allow core .theming in sources [INTERNAL] generateThemeDesignerResources: Allow core .theming in sources Jul 22, 2024
flovogt
flovogt previously approved these changes Jul 23, 2024
RandomByte
RandomByte previously approved these changes Jul 23, 2024
@RandomByte RandomByte dismissed stale reviews from flovogt and themself via 51bab81 July 23, 2024 12:59
@matz3 matz3 merged commit 2337bf5 into main Jul 23, 2024
6 of 19 checks passed
@matz3 matz3 deleted the fix-dot-theming branch July 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants