-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] manifest.json: Auto-fill supportedLocales #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1979d7
to
7e27f80
Compare
matz3
reviewed
Dec 4, 2023
9d33676
to
c214217
Compare
d4e0ca9
to
37903f9
Compare
18 tasks
37903f9
to
471f2fa
Compare
This was referenced Jan 8, 2024
bed067f
to
68d3bb1
Compare
0d5214e
to
f8eb27a
Compare
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
RandomByte
reviewed
Apr 11, 2024
99195d7
to
c5d9cee
Compare
c5d9cee
to
2c2886e
Compare
RandomByte
previously requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small findings
180d183
to
39cddc8
Compare
b857ce4
to
580d3e9
Compare
580d3e9
to
9c3f46d
Compare
matz3
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
87a8a6a
to
f09d85b
Compare
flovogt
added a commit
to SAP/ui5-project
that referenced
this pull request
Jul 12, 2024
JIRA: CPOUI5FOUNDATION-296 Depends on: - SAP/ui5-builder#957 - SAP/ui5-server#617
7b03366
to
517d766
Compare
matz3
previously approved these changes
Jul 12, 2024
4c84c7f
to
26b59e2
Compare
JIRA: CPOUI5FOUNDATION-296
26b59e2
to
c423ade
Compare
matz3
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the UI5 Tooling build, the
supportedLocales
property in themanifest.json
of a UI5 library/application will be filled automatically with the available locales determined by the existence of the respective.properties
file.To disable the automatic generation of the
supportedLocales
, setsupportedLocales
to any desired value.Scenario: Application
In the
manifest.json
thesupportedLocales
property will be enhanced as following:Source
Build Result
JIRA: CPOUI5FOUNDATION-296
Depends on:
Demo: SAP/openui5-sample-app#220