[FEATURE] flexChangesBundler: Merge existing with new flexibility-bundle.json #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexeng06
commented
Jan 15, 2024
alexeng06
commented
- merge existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects
- merge existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects
|
|
| "variants": [] | ||
| }; | ||
|
|
||
| const dummyWorkspace = createDummyWorkspace(changeList, manifest, flexBundle); |
There was a problem hiding this comment.
Maybe workspaceMock would be a good name
matz3
changed the title
matz3
reviewed
Jan 15, 2024
There was a problem hiding this comment.
I've just a few comments that should be clarified before merging this PR.
PS: Are there any other details to take into account with this change? Should the merge happen in all projects, or depending on a specific UI5 version or other project specific details?
- added description for parameter existingFlexBundle
|
This change it mainly for the adaptation project to enable merging changes of the existing base app and the new changes from the adaptation project. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RandomByte
requested changes
Jan 16, 2024
- adjust JSDoc for flexChangesBundler - reduce number of needed JSON.stringify
|
LGTM /AzurePipelines run |
RandomByte
previously approved these changes
Jan 17, 2024
matz3
previously requested changes
Jan 17, 2024
flovogt
reviewed
Jan 17, 2024
- remove unnecessary parameter - adjust JSDoc
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RandomByte
changed the title
RandomByte
approved these changes
Jan 17, 2024
RandomByte
pushed a commit
that referenced
this pull request
Jan 18, 2024
…dle.json Merge any existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects #974
|
Thanks a lot for your contribution. This PR is available with |
matz3
pushed a commit
that referenced
this pull request
Jan 18, 2024
…json Merge any existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects Cherry-pick of #974
matz3
pushed a commit
that referenced
this pull request
Jan 18, 2024
…json Merge any existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects Cherry-pick of #974
matz3
pushed a commit
that referenced
this pull request
Jan 18, 2024
…json Merge any existing level zero changes into the flexibility-bundle.json of UI5 adaptation projects Cherry-pick of #974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.