Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] tests: remove packages 'chai', 'chai-fs' and 'recursive-dir' #994

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Feb 27, 2024

Get rid of chai, chai-fs and recursive-dir.

chai-fs is not compatible with chai@v5. Therefore upgrade to latest chai is not possible.
recursive-dir is no longer required because node supports option recursive: true for native readdir

@coveralls
Copy link

coveralls commented Feb 27, 2024

Coverage Status

coverage: 94.606%. remained the same
when pulling bb3c805 on remove-chai-fs
into d48e745 on main.

@flovogt flovogt requested review from RandomByte and a team February 27, 2024 08:41
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flovogt flovogt merged commit 4af782c into main Feb 27, 2024
17 checks passed
@flovogt flovogt deleted the remove-chai-fs branch February 27, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants