chore(ui5-responsive-popover): migrate wdio tests to cypress #11701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Jun 13, 2025
| </> | ||
| ); | ||
|
|
||
| cy.get("#respPopover").invoke("attr", "open", true); |
There was a problem hiding this comment.
there is custom command for responsive popover which checks whether the component is open and to open it
| </> | ||
| ); | ||
|
|
||
| cy.get("#respPopover").invoke("attr", "open", true); |
There was a problem hiding this comment.
i would switch the id selector to [custom-tag] selector as there is only 1 RP on the page.
| </> | ||
| ); | ||
|
|
||
| cy.get("#btnOpen3").realClick(); |
There was a problem hiding this comment.
do you need to click on the button since RP is programatically opened? same applies for the following tests
| it("header and footer are hidden on desktop", () => { | ||
| cy.mount( | ||
| <> | ||
| <Button id="btnOpen3" /> |
|
|
||
| describe("Acc", () => { | ||
| it("tests accessible-role", () => { | ||
| cy.mount( |
There was a problem hiding this comment.
split these 3 test into 3 smaller ones and add description in the test title what exactly is tested. like: tests accessible-role=AlertDialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3462