Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of changes, fixes and updates #12

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Mowstyl
Copy link
Contributor

@Mowstyl Mowstyl commented Feb 12, 2025

First of all, this update uses PaperMC instead of base Spigot. If that poses a problem, I can try changing some stuff to make it work in Spigot servers. It has also been built for Java 17+, since older versions are not used anymore and they can always use the previous versions of the plugin.

  • Fixed jukeboxes not stopping when they should and overlapping with themselves / the Minecraft disc
  • Fixed music overlapping sometimes (except jukebox + other tracks)
  • Fixed command (playhere? I don't remember the one that was doing something weird) arguments not working as described
  • Added stop commands for both play/playhere and gplay. The gstop command only stops global tracks being played. The stopmidi command stops any tracks (not jukeboxes) being played for a player, including removing them from global ones
  • Added support for target selectors
  • Commands now use Mojang Brigadier system
  • Song suggestions now take into account anything that has been written. Songs that start with whatever the command issuer wrote are shown before songs that contain the partial argument
  • Imitating inserted disc effect seen when inserting vanilla discs
  • Added rarity to disc config, and added said config to reload command
  • When getting the disc of a song added after disc.yml has been generated, said file will be populated with the default values for that song (if it has not been already added manually)

I think that's all. I've tested it on my server, and it works perfectly. Please let me know if I made any mistakes. This is my first time using Brigadier.

@Mowstyl
Copy link
Contributor Author

Mowstyl commented Feb 13, 2025

I found an error in my PlayHere command, let me fix it before considering this.

@Mowstyl
Copy link
Contributor Author

Mowstyl commented Feb 13, 2025

Ok, PlayHere now works like a floating, invisible, intangible jukebox.
I've also added PlayLocation and some more stop MIDI commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants