Prevent single failed download from killing the whole download worker#112
Open
plsdoant wants to merge 1 commit into
Open
Prevent single failed download from killing the whole download worker#112plsdoant wants to merge 1 commit into
plsdoant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When download_video() raised an error for any reason (unavailable, network error, etc.) the exception propagated out of the
while Trueloop and the worker thread died.An except
Exceptionblock was added in the worker loop that catches any error from a single download, logs it and lets the loop continue.Now a video that fails to download is logged and skipped. The worker thread stays alive and continues to process the rest of the queue.