Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format for Trend Micro Vision One #1360

Merged
merged 14 commits into from
Nov 26, 2024
Merged

Conversation

lvoloshyn-sekoia
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 19, 2024

Smart descriptions generated from the latest tests at 2024-11-26 10:12:20:

Test File Smart Description
Trend Micro/trend-micro-vision-one/tests/test_internal_network_scanner.json Internal Network Scanner on 1.2.3.4
Trend Micro/trend-micro-vision-one/tests/test_process.json Credential Dumping via Mimikatz on 10.10.58.51
Trend Micro/trend-micro-vision-one/tests/test_registry.json Privilege Escalation via UAC Bypass on 10.10.58.51

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review November 20, 2024 11:36
uuid: 9844ea0a-de7f-45d4-9a9b-b07651f0630e
automation_connector_uuid: 7aa5dd7c-d694-44dd-b605-66b7974dfb05
automation_module_uuid: 1b02d442-b804-4987-afe7-6a4be6ef35e6
name: Trend Micro Vision One
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Trend Micro Vision One
name: Trend Micro Vision One [BETA]

Comment on lines 28 to 29
organization.name: "{{ (parsed_event.message.impactScope.entities | selectattr('entityType', 'equalto', 'account') | first).entityValue }}"
organization.id: "{{ (parsed_event.message.impactScope.entities | selectattr('entityType', 'equalto', 'account') | first).entityId }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the tests, I wonder if this information should not go into user.domain, user.name and user.id?

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you for the work

@squioc squioc merged commit 6aad4ec into main Nov 26, 2024
7 checks passed
@squioc squioc deleted the lv/trend_micro_vision_one_format branch November 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants