Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Infoblox DDI format improvement #1373

Merged
merged 11 commits into from
Dec 11, 2024
Merged

Fix: Infoblox DDI format improvement #1373

merged 11 commits into from
Dec 11, 2024

Conversation

vg-svitla
Copy link
Contributor

@vg-svitla vg-svitla commented Nov 29, 2024

Closes 306

@vg-svitla vg-svitla requested a review from squioc November 29, 2024 10:45
Copy link

github-actions bot commented Nov 29, 2024

Smart descriptions generated from the latest tests at 2024-12-11 14:07:55:

Test File Smart Description
Infoblox/ddi/tests/query_log.json 192.168.101.70 queried the resolution of docs.sekoia.io
Infoblox/ddi/tests/query_log_category_prefix.json 192.168.101.70 queried the resolution of docs.sekoia.io
Infoblox/ddi/tests/query_log_cd.json 192.168.101.70 queried the resolution of docs.sekoia.io
Infoblox/ddi/tests/query_log_dhcp_1.json 192.168.1.222 perform REQUEST DHCP
Infoblox/ddi/tests/query_log_dhcp_2.json 192.168.1.53 perform REQUEST DHCP
Infoblox/ddi/tests/query_log_dhcp_3.json 192.168.1.107 perform DHCPREQUEST
Infoblox/ddi/tests/query_log_dhcp_4.json 192.168.1.208 perform DHCPREQUEST
Infoblox/ddi/tests/query_log_dhcp_5.json 192.168.1.95 perform DHCPREQUEST
Infoblox/ddi/tests/query_log_dhcp_6.json 192.168.1.159 perform DHCPREQUEST
Infoblox/ddi/tests/query_log_dhcp_7.json 192.168.1.138 perform DHCPACK
Infoblox/ddi/tests/query_log_dhcp_8.json Query from 192.168.1.113
Infoblox/ddi/tests/query_log_dns_1.json Query to 192.168.1.136
Infoblox/ddi/tests/query_log_dns_2.json 192.168.1.1 queried the resolution of test.io
Infoblox/ddi/tests/query_log_dns_3.json 192.168.1.1 queried the resolution of test.org
Infoblox/ddi/tests/query_log_dns_4.json 192.168.1.1 queried the resolution of _ldap._tcp.test.test.net
Infoblox/ddi/tests/query_log_dns_5.json 192.168.1.1 queried the resolution of test.test.io
Infoblox/ddi/tests/query_log_dns_6.json 192.168.1.1 queried the resolution of test.test.org
Infoblox/ddi/tests/query_log_dns_7.json 192.168.1.1 queried the resolution of test.dev
Infoblox/ddi/tests/query_log_dns_8.json 1.2.3.4 queried the resolution of PD2LORA2.enim.l2
Infoblox/ddi/tests/query_log_dns_9.json 1.2.3.4 queried the resolution of www.bing.com
Infoblox/ddi/tests/query_log_dnssec.json 192.168.103.66 queried the resolution of ipv6.google.com
Infoblox/ddi/tests/query_log_edns_version.json 192.168.101.61 queried the resolution of global.vortex.data.trafficmanager.net
Infoblox/ddi/tests/query_log_no_recursion.json 192.168.103.66 queried the resolution of ipv6.google.com
Infoblox/ddi/tests/query_log_reverse.json 192.168.103.66 queried the resolution of 107.100.168.192.in-addr.arpa
Infoblox/ddi/tests/query_log_tcp.json 192.168.101.70 queried the resolution of docs.sekoia.io

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work.
Some changes to apply.

@squioc squioc requested a review from TonioRyo November 29, 2024 15:06
@TonioRyo
Copy link
Contributor

Hello @squioc @vg-svitla,
In 526f766 I added the code to handled DNS answers (that solves some of Sebastien's comments on the PR) and some improvements to set the network.protocol, let me know what you think about it.
I haven't looked at the other comments.
Tonio

@vg-svitla vg-svitla requested a review from squioc December 2, 2024 16:35
@vg-svitla vg-svitla requested a review from squioc December 10, 2024 15:44
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squioc squioc merged commit 0691629 into main Dec 11, 2024
7 checks passed
@vg-svitla vg-svitla deleted the fix/infoblox_ddi_format branch December 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants