Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on cisco.url fields #1385

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Fix on cisco.url fields #1385

merged 7 commits into from
Dec 11, 2024

Conversation

LenaigKaliou
Copy link
Contributor

Fix concerning this issue

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Smart descriptions generated from the latest tests at 2024-12-11 14:00:47:

Test File Smart Description
Cisco/cisco-esa/tests/test_attachments_details.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log1.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log2.json Email from [email protected] to [email protected] was bounced
Cisco/cisco-esa/tests/test_ingest_log3.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log4.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log5.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log6.json Email from [email protected] to [email protected] was delivered
Cisco/cisco-esa/tests/test_ingest_log7.json Email from [email protected] to [email protected] was delayed quarantine
Cisco/cisco-esa/tests/test_ingest_log8.json Email with Message-ID 11111111 was queued
Cisco/cisco-esa/tests/test_ingest_log9.json Email from [email protected] to [email protected] was delivered

squioc
squioc requested changes Dec 10, 2024
View reviewed changes
@LenaigKaliou LenaigKaliou requested a review from squioc December 10, 2024 14:28
lvoloshyn-sekoia
lvoloshyn-sekoia previously requested changes Dec 10, 2024
View reviewed changes
@LenaigKaliou LenaigKaliou requested a review from squioc December 11, 2024 12:54
squioc
squioc approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squioc squioc disabled auto-merge December 11, 2024 14:02
@squioc squioc merged commit ff1dd4b into main Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squioc squioc squioc approved these changes

@TOUFIKIzakarya TOUFIKIzakarya Awaiting requested review from TOUFIKIzakarya

@lvoloshyn-sekoia lvoloshyn-sekoia Awaiting requested review from lvoloshyn-sekoia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LenaigKaliou @squioc @lvoloshyn-sekoia