Skip to content

Hotfix: Netskope Events#2604

Open
vg-svitla wants to merge 1 commit into
developfrom
hotfix/netscope_events
Open

Hotfix: Netskope Events#2604
vg-svitla wants to merge 1 commit into
developfrom
hotfix/netscope_events

Conversation

@vg-svitla

@vg-svitla vg-svitla commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Enhancements:

  • Clean up Netskope events manifest by dropping the automation connector UUID field.

@vg-svitla vg-svitla requested review from a team and mchupeau-sk June 9, 2026 14:30
@sourcery-ai

sourcery-ai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the automation connector UUID from the Netskope Events integration manifest, leaving only the automation module UUID and other core metadata intact.

Entity relationship diagram for Netskope Events manifest hotfix

erDiagram
    NetskopeEventsManifest {
        string uuid
        string automation_module_uuid
    }

    AutomationModule {
        string uuid
    }

    NetskopeEventsManifest }o--|| AutomationModule : references
Loading

File-Level Changes

Change Details Files
Removed the automation connector UUID reference from the Netskope Events manifest to decouple it from a specific automation connector.
  • Deleted the automation_connector_uuid field from the Netskope Events _meta/manifest.yml.
  • Preserved the existing uuid, automation_module_uuid, name, and slug fields without modification.
Netskope/netskope_events/_meta/manifest.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Confirm that removing automation_connector_uuid from this manifest is consistent with the expected schema for all similar Netskope manifests so that configuration fields remain aligned across integrations.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Confirm that removing `automation_connector_uuid` from this manifest is consistent with the expected schema for all similar Netskope manifests so that configuration fields remain aligned across integrations.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Copilot Automated Review

Changed Intake Formats

The following intake formats were modified:

  • 'Netskope/netskope_events'

Changed File Types

  • .yml files: 1

🔒 Security Scan - Sensitive Information Check

⚠️ IMPORTANT: This is a public repository. All test data must be anonymized.

No test files in this PR

📋 Contribution Checklist

Please ensure your PR meets the following requirements:

  • No sensitive information in test files (emails, passwords, API keys, real IPs, PII)
  • Test data is properly anonymized (use example.com, TEST-NET IPs, fake credentials)
  • Code is linted with Prettier
  • Parser test coverage is at least 75%
  • Logo files included for new modules/formats
  • README.md files present and updated
  • Smart-descriptions provided for new formats

🔍 Next Steps

GitHub Copilot can help you with:

  • Security review: Tag @copilot to scan for additional sensitive data
  • Anonymization help: Ask Copilot to suggest anonymized replacements
  • Code review: Request specific review feedback
  • Test suggestions: Ask Copilot to suggest additional test cases

For more details, see the Contribution Guidelines.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Smart descriptions generated from the latest tests at 2026-06-09 14:31:26:

Test File Smart Description
Netskope/netskope_events/tests/test_anomaly_shared_credentials.json Shared Credentials detected for user user1@example.com
Netskope/netskope_events/tests/test_audit_log_deleted_inline_policy.json Administrative changes done by john.doe@example.org: Deleted inline policy
Netskope/netskope_events/tests/test_audit_log_edit_admin_record.json Administrative changes done by john.doe@example.org: Edit admin record
Netskope/netskope_events/tests/test_audit_log_login_failed.json Authentication failed for student13 on the Netskope console
Netskope/netskope_events/tests/test_audit_log_login_successful.json john.doe@example.org signed in the Netskope console
Netskope/netskope_events/tests/test_audit_log_logout_successful.json john.doe@example.org signed out the Netskope console
Netskope/netskope_events/tests/test_audit_log_password_change_successful.json Administrative changes done by john.doe@example.org: Password Change Successful
Netskope/netskope_events/tests/test_connection_log.json 3.3.3.3 requested test.example.org
Netskope/netskope_events/tests/test_dlp_alert.json DLP Alert ML-TYOC-QRCode on host HOSTNAME - file HighRes_QRCode_3.png
Netskope/netskope_events/tests/test_dlp_incident.json DLP incident detected: [DLP] Block sensitive files on Cloud Storage
Netskope/netskope_events/tests/test_dlp_incident_2.json DLP incident detected: Alert No label files to be Sent to Unsanctioned App
Netskope/netskope_events/tests/test_dlp_incident_3.json 1.1.1.1 requested example.net/pageview
Netskope/netskope_events/tests/test_dlp_incident_wo_policy.json DLP Alert ML-TYOC-QRCode on host HOSTNAME - file HighRes_QRCode_3.png
Netskope/netskope_events/tests/test_malsite_alert.json Traffic from 1.1.1.1 to 3.3.3.3/ was blocked by rule Security Risk
Netskope/netskope_events/tests/test_malware_alert.json Malicious software eicarcom2.zip detected on 3.3.3.3. action: Download
Netskope/netskope_events/tests/test_network_1.json User john.doe connected to 1.1.1.1
Netskope/netskope_events/tests/test_network_2.json User john.doe connected to 1.1.1.1
Netskope/netskope_events/tests/test_nspolicy_block.json Traffic from 1.1.1.1 to test.example.com was blocked by rule Block DoH - incompatibility with Netskope
Netskope/netskope_events/tests/test_nspolicy_log.json 2.2.2.2 requested sharepoint.example.com/sites/mysite/_layouts/0/download.aspx
Netskope/netskope_events/tests/test_nspolicy_upload.json 1.1.1.1 requested urll.app.example.com/object2.txt
Netskope/netskope_events/tests/test_securitycheck_dlp_exposure.json Traffic from 2.3.4.5 to onedrive.example.com/upload was blocked by rule Block PCI Data
Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json Traffic from 2.3.4.5 to malicious.example.test/ was blocked by rule Threat Protection
Netskope/netskope_events/tests/test_securitycheck_malware_sandbox.json Malicious software sample.exe detected on 2.3.4.5. action: Download
Netskope/netskope_events/tests/test_user_alert.json Suspicious traffic from 2.2.2.2 to example.org/api/v4/transfers/email

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ Intake Format Checks Failed

Format Errors

  • Netskope/netskope_events
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident.json - data type: URL - value: storage.example.org/files/eicar.txt - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident.json - data type: Account ID - value: example.org - reason: Not an accepted anonymized account identifier
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_user_alert.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_user_alert.json - data type: Domain - value: TEST-1234 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_user_alert.json - data type: URL - value: example.org/api/v4/transfers/email - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: IP Address - value: 2.3.4.5 - reason: Not in accepted anonymized IP ranges
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: Domain - value: workstation1 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: Domain - value: malicious.example.test - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: Domain - value: malicious.example.test - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: URL - value: https://malicious.example.test/ - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malsite_threat.json - data type: URL - value: malicious.example.test/ - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_dlp_exposure.json - data type: IP Address - value: 2.3.4.5 - reason: Not in accepted anonymized IP ranges
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_dlp_exposure.json - data type: Domain - value: workstation1 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_dlp_exposure.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_dlp_exposure.json - data type: URL - value: onedrive.example.com/upload - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident_wo_policy.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident_wo_policy.json - data type: URL - value: www.example.com/dms/prv/vid/v2/abc/messaging-attachmentFile/messaging-attachmentFile/0/123 - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_network_2.json - data type: Domain - value: Windows - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_network_1.json - data type: Domain - value: Windows - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malware_alert.json - data type: Domain - value: Monterey - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malware_alert.json - data type: URL - value: secure.example.org/eicarcom2.zip - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_log.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_log.json - data type: URL - value: sharepoint.example.com/sites/mysite/_layouts/0/download.aspx - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_log.json - data type: Account ID - value: Example - reason: Not an accepted anonymized account identifier
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malware_sandbox.json - data type: IP Address - value: 2.3.4.5 - reason: Not in accepted anonymized IP ranges
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malware_sandbox.json - data type: Domain - value: workstation1 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malware_sandbox.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_securitycheck_malware_sandbox.json - data type: URL - value: www.example.com/downloads/sample.exe - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_connection_log.json - data type: URL - value: test.example.org - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident_3.json - data type: Domain - value: hostnametest - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident_3.json - data type: Domain - value: Windows 10 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_incident_3.json - data type: URL - value: example.net/pageview - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malsite_alert.json - data type: Domain - value: Windows 10 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malsite_alert.json - data type: Domain - value: 3.3.3.3 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malsite_alert.json - data type: Domain - value: 3.3.3.3 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malsite_alert.json - data type: URL - value: https://3.3.3.3/ - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_malsite_alert.json - data type: URL - value: 3.3.3.3/ - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_upload.json - data type: Domain - value: Windows 10 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_upload.json - data type: URL - value: urll.app.example.com/object2.txt - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_block.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_nspolicy_block.json - data type: URL - value: test.example.com - reason: Not using accepted anonymized domain in URL
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_audit_log_login_failed.json - data type: Username - value: student13 - reason: Not in accepted anonymized username patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_audit_log_login_failed.json - data type: Email - value: student13 - reason: Not using accepted anonymized email domain
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_alert.json - data type: Domain - value: Windows 11 - reason: Not in accepted anonymized domain patterns
    • Anonymization Error - code: anonymization_missing - file: Netskope/netskope_events/tests/test_dlp_alert.json - data type: URL - value: www.example.com/dms/prv/vid/v2/D4E06AQGUErrV59qj9A/messaging-attachmentFile/messaging-attachmentFile/0/1733925708482 - reason: Not using accepted anonymized domain in URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant