Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve openapi to module script #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Darkheir
Copy link
Collaborator

@Darkheir Darkheir commented Feb 27, 2025

The following improvements have been added:

  • Add support for authentication schemes
    • Currently on basic, apiKey and bearer are supported the headers or as query parameter
  • Set base url if available in the schema
  • Improve parsing of parameters to include more attributes and take into account requestBody
  • Allow schemas that are defined in yaml
  • Fix wrong regex to replace unsupported characters
  • Take into account the base path of the endpoints if defined

@Darkheir Darkheir force-pushed the feat/improve_openpi_to_module branch from 6846431 to 5528c8f Compare February 27, 2025 14:15
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (f18bea4) to head (01bfc27).

Files with missing lines Patch % Lines
sekoia_automation/scripts/openapi.py 90.54% 7 Missing ⚠️
sekoia_automation/action.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   90.76%   90.80%   +0.04%     
==========================================
  Files          35       36       +1     
  Lines        2500     2568      +68     
==========================================
+ Hits         2269     2332      +63     
- Misses        231      236       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 27, 2025

Test Results

224 tests  +2   223 ✅ +2   1m 54s ⏱️ +11s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 01bfc27. ± Comparison against base commit f18bea4.

♻️ This comment has been updated with latest results.

@Darkheir Darkheir force-pushed the feat/improve_openpi_to_module branch from 5528c8f to 490b259 Compare February 27, 2025 14:33
@Darkheir Darkheir force-pushed the feat/improve_openpi_to_module branch from 490b259 to ee40386 Compare February 27, 2025 14:43
@Darkheir Darkheir requested review from squioc and otetard February 27, 2025 14:51
@Darkheir Darkheir force-pushed the feat/improve_openpi_to_module branch from aaf517d to 705ab84 Compare February 28, 2025 11:00
@Darkheir Darkheir force-pushed the feat/improve_openpi_to_module branch from 705ab84 to c4386e8 Compare February 28, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant