-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DAH-3187 update FCFS how to apply link translations #2513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
@jimlin-sfgov not yet, I can do that! My understanding from our team eng sync is that we decided to remove the translations checkbox for the PR review template and work with Bridget to update Phrase before sending each round instead. |
@cliu02 I guess we didn't make it clear enough during eng. sync. For the "standard" workflow of adding new translations, engineers do not need to interact with Phrase. For other translation workflows, there are additional steps that needed to be followed in the guide. Especially for this PR's case, changes must be made in Phrase first, otherwise it becomes problematic for whoever manages the next batch of human translations. |
@jimlin-sfgov got it sorry about that, @chadbrokaw has helped update these strings in Phrase! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Update translations for FCFS how to apply link.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3187
Before requesting eng review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
. If the PR is urgent and does not need a ticket then use the formaturgent: Description
Code quality
Review instructions
Request eng review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptance
label to indicate that the PR is waiting for PA testing)