fix: DAH-3208 Change Home SF name #2545
Open
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadbrokaw
requested review from
cliu02,
a team and
tallulahkay
and removed request for
a team
cade-exygy
approved these changes
Feb 6, 2025
chadbrokaw
force-pushed
the
DAH-3208_change_home_sf_name
branch
from
326aa3a to
9656407
Compare
chadbrokaw
force-pushed
the
DAH-3208_change_home_sf_name
branch
from
9656407 to
30fb254
Compare
chadbrokaw
added
needs product acceptance
chadbrokaw
commented
Feb 10, 2025
| @@ -981,7 +981,7 @@ | |||
| "listings.apply.sendByUsMail": "Send Application by US Mail", | |||
| "listings.apply.submitAPaperApplication": "Submit a Paper Application", | |||
| "listings.apply.visitAHousingCounselor": "Visit a local housing counselor for help with your application.", | |||
| "listings.apply.visitHomeownershipSf": "Visit HomeownershipSF", | |||
| "listings.apply.visitHomeownershipSf": "Visit Home SF", | |||
There was a problem hiding this comment.
This string isn't being used anywhere in the React code, but I am moving it over anyway
chadbrokaw
commented
Feb 10, 2025
| @@ -103,8 +103,8 @@ | |||
| "assistance.housingCounselors.findACounselor.filter.selectPlaceholder.anyLangauge": "Cualquier idioma", | |||
| "assistance.housingCounselors.findACounselor.filter.seniorOnlyServices": "Servicios exclusivos para adultos mayores", | |||
| "assistance.housingCounselors.findACounselor.filter.zero.part1": "Se muestran 0 coincidencias:", | |||
| "assistance.housingCounselors.findACounselor.filter.zero.part2": "Para ampliar la búsqueda, cambie el filtro. O bien <a href='/housing-counselors#homeownership-sf'>póngase en contacto con un representante del programa Homeownership de San Francisco</a> y encuentre a un asesor de vivienda que se adapte a sus necesidades.", | |||
| "assistance.housingCounselors.findACounselor.subtitle": "Puede utilizar este filtro para encontrar a un asesor de vivienda que se adapte a sus necesidades. Si necesita ayuda para encontrar a un asesor de vivienda que se adapte a sus necesidades, póngase en contacto con un representante del programa Homeownership de San Francisco.", | |||
| "assistance.housingCounselors.findACounselor.filter.zero.part2": "Para ampliar la búsqueda, cambie el filtro. O bien <a href='/housing-counselors#home-sf'>póngase en contacto con un representante del programa Home SF</a> y encuentre a un asesor de vivienda que se adapte a sus necesidades.", | |||
There was a problem hiding this comment.
I will make these changes in Phrase once they are approved
tallulahkay
approved these changes
Feb 10, 2025
cade-exygy
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the HomeownershipSF name to be HomeSF and updates the url and email.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3208
Before requesting eng review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, e.g.feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the formaturgent: DescriptionCode quality
Review instructions
Request eng review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptancelabel to indicate that the PR is waiting for PA testing)