Resolves #8 : Add support for metadata exported by the ARRI Reference Tool#201
Open
JGoldstone wants to merge 1 commit intomainfrom
Open
Resolves #8 : Add support for metadata exported by the ARRI Reference Tool#201JGoldstone wants to merge 1 commit intomainfrom
JGoldstone wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ARRI cameras that can record lens metadata for entrance pupil offset (and effective focal length) do not have command-line tools that generate the CSV files currently supported by
camdkitfor ARRI camera metadata import. Instead, those cameras are supported by a command-line tool that is a version of the ARRI Reference Tool, said command-line tool being namedart-cmd, that generates JSON.This PR adds support for importing JSON metadata generated by the command-line version of the ARRI Reference Tool. It contains test metadata from the ALEXA 35 Extreme, the ALEXA 265, the ALEXA 35, the ALEXA Mini LF, the ALEXA LF, the ALEXA Mini and the ALEXA SXT. The source code contains comments noting special cases (e.g. on some older cameras, rather than omitting physical width and height of the sensor, a size of 0.0 x 0.0 is emitted) of which someone adapting the logic embodied in this PR into their own code would want to be aware.