Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine TWF by adding independent mus and mud and a special twf for TPV22; Update the corresponding user manual #1693

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Huihuiweng
Copy link
Contributor

Add a special kind of TWF for TPV benchmarks

Revise a bug in special TWF

minor changes

small bug

Update 06_fault_sources.tex in user manual

Add a special kind of TWF for TPV benchmarks

Revise a bug in special TWF

minor changes

small bug

Update 06_fault_sources.tex in user manual
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 25.64%. Comparing base (7a1c764) to head (8cc2623).

Files Patch % Lines
src/specfem3D/fault_solver_dynamic.f90 0.00% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #1693       +/-   ##
===========================================
- Coverage   51.53%   25.64%   -25.90%     
===========================================
  Files         267      233       -34     
  Lines       60735    50224    -10511     
===========================================
- Hits        31302    12880    -18422     
- Misses      29433    37344     +7911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Huihuiweng
Copy link
Contributor Author

Huihuiweng commented Apr 25, 2024

What are the causes of the failure of CI /Test on Mac? This is weird because I can successfully compile it on my computer.

@danielpeter danielpeter merged commit ce914f7 into SPECFEM:devel Apr 25, 2024
22 of 36 checks passed
@danielpeter
Copy link
Member

will figure out the issues later, seems to be related to MPI and the parallel code compilation...

@Huihuiweng
Copy link
Contributor Author

will figure out the issues later, seems to be related to MPI and the parallel code compilation...

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file caused the test problems - it shouldn't be included as it is a pre-compiled module file that only works for specific compilers & systems. i will take it out in the next PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants