Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using shellcode env with pkgx #1119

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Avoid using shellcode env with pkgx #1119

merged 7 commits into from
Jan 21, 2025

Conversation

waliid
Copy link
Member

@waliid waliid commented Jan 20, 2025

Description

This PR fixes an issue with pkgx. Indeed, since there is no longer shellcode env support in pkgx, some of our scripts were failing.

Shellcode

The pkgx suite has had its scopes tightened. There is no shellcode in pkgx
anymore.

Changes made

  • Use pkgx directly instead of using shellcode env.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid self-assigned this Jan 20, 2025
@waliid waliid enabled auto-merge January 20, 2025 17:53
@waliid waliid force-pushed the fix-pkgx branch 2 times, most recently from df8a84e to 1b711cb Compare January 21, 2025 12:57
@waliid waliid added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 40d1d52 Jan 21, 2025
7 checks passed
@waliid waliid deleted the fix-pkgx branch January 21, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants