-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate .opam and CI from coq-community/templates #23
base: main
Are you sure you want to change the base?
Conversation
It seems Github Action doesn't like the generated action:
EDIT: It's fixed. |
I think this is a good idea but there is some limitations. With the current CI the opam packages are cached after the first run. |
Ah indeed. I don't know what would be the best then. Do you think we can modify the new CI script by hand to recover caching or if there's something inherently wrong with the image we're using? (I'm not so familiar with this stuff so I had hoped that the people that did the template knew better). |
Maybe we could copy the .opam directory out of the container before it is destroyed? Alternatively, we could make our own docker image with all the dependencies and then base the CI on that. |
Well, but the point is to check also that you can install SSProve with the curent opam recipe so we avoid things like #20 no? |
That's a good point. I imagine that this error would not have been caught if the CI worked on a cached opam with a different package in the allowed interval? If the opam recipe is restrictive enough then the cache would only need to change when the recipe is updated. |
Right. It would have required a manual rerun of the action I guess… |
It seems we can still use some caching, but I don't know how relevant it is for us: https://github.com/coq-community/templates/blob/master/ref.yml#L478 |
The idea is to use https://github.com/coq-community/templates so that we probably use something more principled for our CI jobs. The template can do more but I'd say we're good with these two files for now.