Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kiosk containers from home:atgracey:wallboardos #2210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Kiosk containers from home:atgracey:wallboardos #2210

wants to merge 1 commit into from
+334 −0

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Jan 17, 2025

@dcermak dcermak force-pushed the kios-ctr branch 3 times, most recently from b4e784a to 11a0955 Compare January 17, 2025 14:08
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
3791abd
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
a5e878b
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
3fcad37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2210
Changes pushed to branch 6-2210 as commit ce31a476d4b82663cd24046f65ec4481ea989ffd
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for s390x: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for ppc64le: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for s390x: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2210 for ppc64le: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2210/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2210/containerfile/suse/kiosk-firefox-esr:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2210/containerfile/suse/pulseaudio:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2210/containerfile/suse/xorg:latest

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2210
Changes pushed to branch Tumbleweed-2210 as commit ec42377c364de893a61b9750628ef18d6d2c13f2
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2210/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2210/containerfile/opensuse/kiosk-firefox:latest
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2210/containerfile/opensuse/pulseaudio:latest
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2210/containerfile/opensuse/xorg:latest

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2210
Changes pushed to branch 7-2210 as commit 44174e750b916c29b1a1760665ceab06c1b60cbf
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for s390x: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for ppc64le: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for x86_64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for aarch64: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ✅ succeeded live log
pulseaudio-image ✅ succeeded live log
xorg-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for s390x: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2210 for ppc64le: current state: published
Build results:

package name status build log
kiosk-firefox-esr-image ⛔ excluded live log
pulseaudio-image ⛔ excluded live log
xorg-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2210/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2210/containerfile/suse/kiosk-firefox-esr:128.7
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2210/containerfile/suse/pulseaudio:17
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2210/containerfile/suse/xorg:21

dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
7b6b8db
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
6793cc8
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
5197dc9
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
3b82fd8
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
621fcbd
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
e2aab6c
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
ae2d709
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
75e6cb5
dcermak pushed a commit that referenced this pull request Jan 17, 2025
Test build for #2210
c2e7d52
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
82e75f2
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
aa9f32d
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
e6114f2
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
0f915ad
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
e9eb1ab
dcermak pushed a commit that referenced this pull request Jan 20, 2025
Test build for #2210
0ddc5ee
dirkmueller
dirkmueller reviewed Feb 11, 2025
View reviewed changes
src/bci_build/package/kiosk.py Outdated
"xorg.conf": (_x11_dir / "xorg.conf").read_text(),
}

X11_CONTAINERS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please split that into a x11.py ? given that we have files in x11/ subdir that would be more aligned and easier to maintain going forward imho.

also, not trying to be too nitpicky, but you're packaging xorg not X11 (that would be from the times before you were born..). can we just call it XORG instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please split that into a x11.py ? given that we have files in x11/ subdir that would be more aligned and easier to maintain going forward imho.

No, these three containers belong together imho

also, not trying to be too nitpicky, but you're packaging xorg not X11 (that would be from the times before you were born..). can we just call it XORG instead?

I have renamed it xorg instead of x11

dirkmueller
dirkmueller reviewed Feb 11, 2025
View reviewed changes
src/bci_build/package/kiosk.py
"system.pa": (_pa_dir / "system.pa").read_text(),
}

PULSEAUDIO_CONTAINERS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into a pulseaudio.py for the same reason like x11 (see below) ?

@dirkmueller
Copy link
Member

It sorta kinda works

missing fonts?

dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
f2821b9
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
89afbbd
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
d9cf44d
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
2552ff7
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
8028c84
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
a177e00
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
e9791fc
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
52f8fcc
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
7e539c1
@dcermak
Copy link
Collaborator Author

dcermak commented Feb 12, 2025

It sorta kinda works

missing fonts?

Yes, I hope it's fixed now. It worked locally, but I have to test the images from OBS too

@dcermak
Copy link
Collaborator Author

dcermak commented Feb 12, 2025

It works, but the VM doesn't play any sound atm
image

dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
386d8bf
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
de4f56b
dcermak pushed a commit that referenced this pull request Feb 12, 2025
Test build for #2210
eeb8d97
dcermak pushed a commit that referenced this pull request Feb 14, 2025
Test build for #2210
ec42377
dcermak pushed a commit that referenced this pull request Feb 14, 2025
Test build for #2210
44174e7
dcermak pushed a commit that referenced this pull request Feb 14, 2025
Test build for #2210
ce31a47
@dcermak dcermak marked this pull request as ready for review February 18, 2025 10:24
@dcermak dcermak mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agracey agracey agracey left review comments

@dirkmueller dirkmueller dirkmueller left review comments

@alexandrevicenzi alexandrevicenzi alexandrevicenzi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcermak @dirkmueller @agracey @alexandrevicenzi