Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile.integration: use sesdev create --salt #701

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

tserong
Copy link
Member

@tserong tserong commented Jun 21, 2023

After looking through ceph-salt logs from previous failed Jenkins runs, and also at Volker's issue which seems to be the same thing (see #700), my current suspicion is that the ceph-salt executor is correctly starting salt -G 'ceph-salt:member' state.apply ceph-salt but is then failing to pick up some (or all) of the event notifications, which results in it returning too soon, while cephadm bootstrap is still running.

Assuming I'm on the right track here, let's ask sesdev to run that salt command directly, to remove the ceph-salt executor from the picture entirely.

After looking through ceph-salt logs from previous failed Jenkins
runs, and also at Volker's issue which seems to be the same thing
(see #700), my current
suspicion is that the ceph-salt executor is correctly starting
`salt -G 'ceph-salt:member' state.apply ceph-salt` but is then
failing to pick up some (or all) of the event notifications, which
results in it returning too soon, while `cephadm bootstrap` is
still running.

Assuming I'm on the right track here, let's ask `sesdev` to run
that salt command directly, to remove the ceph-salt executor
from the picture entirely.

Signed-off-by: Tim Serong <[email protected]>
@tserong tserong requested a review from kshtsk June 21, 2023 11:09
Copy link
Contributor

@kshtsk kshtsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks trivial

@tserong tserong marked this pull request as draft June 21, 2023 22:24
@tserong
Copy link
Member Author

tserong commented Jun 21, 2023

OK, did not expect that to fail :-/

In one recent CI run, the salt minion never returned and
the salt minion log and cephadm.out log just stopped dead
immediately after `cephadm bootstrap` was invoked.  This
commit collects `ps` and `journalctl` output in the hope
that this will help with further debugging if we hit this
issue again.

Signed-off-by: Tim Serong <[email protected]>
@tserong tserong force-pushed the wip-dont-use-ceph-salt-executor branch from 8c48614 to ded1bde Compare June 22, 2023 00:18
@tserong tserong marked this pull request as ready for review June 22, 2023 00:18
@tserong
Copy link
Member Author

tserong commented Jun 22, 2023

The first CI run (http://see.prv.suse.net:8080/blue/organizations/jenkins/sesdev-integration/detail/PR-701/1/ failed with:

    master: ++ salt -G ceph-salt:member state.apply ceph-salt
    master: master.mini.test:
    master:     Minion did not return. [No response]
    master:     The minions may not have all finished running and any remaining minions will return upon completion. To look up the return data for this job later, run the following command:
    master: 
    master:     salt-run jobs.lookup_jid 20230621113458675257
    master: ERROR: Minions returned with non-zero exit code

So then I added ded1bde to collect more artifacts, but of course now everything is fine again - http://see.prv.suse.net:8080/blue/organizations/jenkins/sesdev-integration/detail/PR-701/4/ succeeded.

There's obviously still some intermittent problem :-/ but now we'll have even more stuff for me to look at next time it fails.

@tserong tserong requested a review from kshtsk June 22, 2023 05:35
Copy link
Contributor

@kshtsk kshtsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bless you

@tserong tserong merged commit 36553b0 into master Jun 22, 2023
@tserong tserong deleted the wip-dont-use-ceph-salt-executor branch June 22, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants