SWC-6627 - Add new CreateTableViewWizard, replace ColumnModelsEditor with React implementation #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrate CreateTableViewWizard from SRC - Delete old CreateTableViewWizard, Step1, Step2 - Update ADD_TABLE action to open the new wizard - Remove actions ADD_FILE_VIEW, ADD_PROJECT_VIEW, ADD_SUBMISSION_VIEW, ADD_MATERIALIZED_VIEW, ADD_VIRTUAL_TABLE - Move remaining constants out of deleted files Requires an upgrade to synapse-react-client
nickgros
changed the title
nickgros
commented
Jan 25, 2024
| return createTableHeader | ||
| }) | ||
|
|
||
| await test.step('enter table name and description', async () => { |
There was a problem hiding this comment.
Because the wizard changed the order of the steps, this test step was moved down
nickgros
commented
Jan 25, 2024
There was a problem hiding this comment.
This is massively simplified now that the logic is in TS/React
nickgros
commented
Jan 25, 2024
There was a problem hiding this comment.
Lots of logic for the editor also lived in this class, so it also becomes massively simplified
jay-hodgson
reviewed
Jan 25, 2024
| @@ -485,6 +485,10 @@ | |||
| srcPath = cdnEndpoint + 'generated/synapse-react-client.development.js' | |||
| } | |||
|
|
|||
| // TODO: Workaround for SWC-6664 | |||
| // Override the conditional above and just use the production distribution | |||
| reactQueryPath = cdnEndpoint + 'generated/react-query.production.min.js' | |||
There was a problem hiding this comment.
Please remove the assignments to reactQueryPath above this one (ln 478 and 484) for clarity.
jay-hodgson
approved these changes
Jan 25, 2024
|
e2e tests passing: https://github.com/nickgros/SynapseWebClient/actions/runs/7669476841 |
nickgros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.