Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge changes from release-488 to develop #5292

Merged
merged 7 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ extras/
/.sass-cache/
.idea/*

src/main/main.iml
src/test/test.iml

# We use a maven plugin to download node and required modules.
# Since these are retrieved at build-time, no need to commit.
node/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public interface OnViewSharingSettingsHandler {
SynapseTableProps tableConfiguration;

@JsNullable
boolean defaultShowFacetVisualization;
boolean defaultShowPlots;

boolean showLastUpdatedOn;

Expand All @@ -79,7 +79,7 @@ public static QueryWrapperPlotNavProps create(
props.downloadCartPageUrl = "#!DownloadCart:0";
props.showLastUpdatedOn = false;
// SWC-6138 - hide charts by default
props.defaultShowFacetVisualization = false;
props.defaultShowPlots = false;
return props;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
xmlns:t="urn:import:org.sagebionetworks.web.client.view.bootstrap.table"
>
<g:HTMLPanel>
<t:Table ui:field="table" styleName="table table-striped table-condensed">
<t:Table
ui:field="table"
styleName="table table-striped table-condensed whiteBackground"
>
<!-- <t:THead> <t:TableRow> <t:TableHeader> <b.html:Text>Key</b.html:Text>
</t:TableHeader> <t:TableHeader> <b.html:Text>Value</b.html:Text> </t:TableHeader>
</t:TableRow> </t:THead> -->
Expand Down
Loading