SWC-6668: implement react-component for editing the definingSql #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table instead of GWT
nickgros
reviewed
Feb 19, 2024
| @@ -405,6 +407,7 @@ public void before() { | |||
| PromptForValuesModalView.Configuration.Builder.class, | |||
| new SelfReturningAnswer() | |||
| ); | |||
| // when(mockMaterializedView.getId()).thenReturn(entityId); | |||
There was a problem hiding this comment.
Suggested change
| // when(mockMaterializedView.getId()).thenReturn(entityId); |
nickgros
reviewed
Feb 19, 2024
| @JsType(isNative = true, namespace = JsPackage.GLOBAL, name = "Object") | ||
| public class SqlDefinedTableEditorModalProps extends ReactComponentProps { | ||
|
|
||
| // going to match the props sent from src |
There was a problem hiding this comment.
Suggested change
| // going to match the props sent from src |
nickgros
reviewed
Feb 19, 2024
| @FunctionalInterface | ||
| @JsFunction | ||
| public interface OnUpdate { | ||
| void OnUpdate(); |
There was a problem hiding this comment.
camelCase for consistency. You could also just define one Callback interface for both onUpdate and onCancel, but that's up to you
Suggested change
| void OnUpdate(); | |
| void onUpdate(); |
nickgros
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…table instead of GWT