Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check config for enabling schematic validate cross manifest validatio… #599

Merged
merged 1 commit into from
Jun 6, 2024
Merged

check config for enabling schematic validate cross manifest validatio… #599

merged 1 commit into from
Jun 6, 2024

Conversation

afwillia
Copy link
Contributor

@afwillia afwillia commented Jun 4, 2024 •
edited
Loading

…n. Remove project scope from validation query

  • Super simple, just check for the enable_cross_manifest_validation value in the config. Then comment out project_scope in the manifest/validate query to use the default scope.

see Sage-Bionetworks/data_curator_config#179 for the config changes.

@afwillia
check config for enabling schematic validate cross manifest validatio…
7a6859d 
…n. Remove project scope from validation query
@afwillia afwillia requested a review from lakikowolfe June 4, 2024 19:43
@afwillia afwillia changed the base branch from main to develop June 4, 2024 19:44
lakikowolfe
lakikowolfe approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lakikowolfe lakikowolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in code review 6/5

@afwillia afwillia merged commit 486a221 into develop Jun 6, 2024
1 of 3 checks passed
@afwillia afwillia deleted the FDS-1981-cross-manifest-validation branch June 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakikowolfe lakikowolfe lakikowolfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afwillia @lakikowolfe