ci(sage-monorepo): try sonar scan again for PRs originating from forks (

#2460)

* Touch two OC projects

* Require label `sonar-scan-appproved` to run Sonar

* Remove hard coded PR number

.github/workflows/sonar-scan.yml

@@ -1,14 +1,15 @@
 name: Scan affected projects with Sonar
 on:
   pull_request_target:
-    types: [opened, synchronize, reopened]
+    types: [opened, synchronize, reopened, labeled]
 
 env:
   HEAD_REF: ${{ github.event.pull_request.head.ref }}
   HEAD_REPOSITORY: ${{ github.event.pull_request.head.repo.full_name }}
 
 jobs:
-  push:
+  sonar:
+    if: contains(github.event.pull_request.labels.*.name, 'sonar-scan-approved')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

apps/openchallenges/app/src/app/app.component.html

@@ -1,4 +1,5 @@
 <openchallenges-google-tag-manager *ngIf="useGoogleTagManager" />
+<!-- XXX -->
 <openchallenges-navbar
   class="mat-elevation-z6"
   [title]="title"

apps/openchallenges/organization-service/src/main/java/org/sagebionetworks/openchallenges/organization/service/OrganizationServiceApplication.java

@@ -10,7 +10,6 @@
 import org.springframework.cloud.openfeign.EnableFeignClients;
 import org.springframework.context.annotation.ComponentScan;
 
-// XXX to trigger Sonar scan
 @ComponentScan(basePackages = {"org.sagebionetworks.openchallenges"})
 @EnableEurekaClient
 @EnableFeignClients

tools/sonar-scanner.sh

@@ -103,8 +103,6 @@ args=(
   -Dsonar.python.coverage.reportPaths=${project_dir}/coverage.xml
 )
 
-pull_request_number=2458
-
 # Include the PR key if specified
 if [[ ! -z ${pull_request_number+z} ]];
 then