-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematic): add generate manifest endpoint #2431
feat(schematic): add generate manifest endpoint #2431
Conversation
* changed authenticication so that only endpoints that need it have it * updated schematic * add patch for access token * schema endpoints no longer mockeed * added tests for handle exceptions * added integration tests * marked synapse tests * added error handling for bad schema urls * fix error message * add workflow for end to end testing * fix some test results * add unit mark * add unit mark * add workflow for testing with secrets * rename file * fix synapse test file when secrets file doesnt exists * fix test workflows * turned synapse ids into secrets in workflow * turned synapse ids into secrets in workflow
|
@tschaffter I'm a bit of a rebase noob. Could you elaborate on what I should do exactly? |
Caution Rebasing means rewriting the history of a branch (more on that below). When pushing the new history to a remote (GitHub), some commits are deleted and replaced by new ones. Please don't run any of the commands listed below unless you understand what they do. Feature branches must start from the latest version of the upstream
Here is how you create a new feature branch when you are currently in your fork's
Your feature branch is meant to be merged to the
One drawback of this approach is that the commit history of your feature branch can become crowded with "Merged from main...". It's fine for a feature branch but it is discouraged for the Another way to update your feature branch is to rebase it using the branch from which you created it (usually [commits in to [commits in After updating your
Your feature branch lives in two places: locally and remotely (GitHub). Typically, you update the remote branch with:
If you have rebased your local branch since the last time you pushed it, git will complain because you are attempting to rewrite the history of your remote branch. If this is what you want to do, and the answer is "yes" in the context of this tutorial, then you need to force the push:
Finally, it's fine to rebase a local branch whenever you want, especially if this branch has never been pushed to a remote (e.g. your fork on GitHub). However, you should be careful when modifying the history of a "public" branch, i.e. a branch visible to other developers who may rely on it in one way or another. By rewriting the history of a branch on GitHub, you are effectively deleting [commits in your feature branch] before creating new [commits in your feature branch] (the commits in this list will have different commit IDs). |
@linglp Have you had a chance to review this? |
06269d9
into
Sage-Bionetworks:Schematic-API-Staging
manifest_generator_contriller_impl
utils:
storage_controler_impl
tangled_tree_controler_impl
schema_controller_impl