ci(sage-monorepo): parametrize sonar scanner tool #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaffter
changed the title
tschaffter
requested review from
andrewelamb,
GiaJordan,
linglp,
mialy-defelice,
milen-sage,
rrchai and
vpchung
as code owners
|
|
andrewelamb
added a commit
that referenced
this pull request
Jan 26, 2024
* feat(schematic): integration testing (#2398) * changed authenticication so that only endpoints that need it have it * updated schematic * add patch for access token * schema endpoints no longer mockeed * added tests for handle exceptions * added integration tests * marked synapse tests * added error handling for bad schema urls * fix error message * add workflow for end to end testing * fix some test results * add unit mark * add unit mark * add workflow for testing with secrets * rename file * fix synapse test file when secrets file doesnt exists * fix test workflows * turned synapse ids into secrets in workflow * turned synapse ids into secrets in workflow * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * Update schematic-api-ci.yml * add paging, and split connected noeds into two endpoints * paginated preoject datasets query * paginated preoject datasets query * paginated dataset files endpoint * pagniate project manifests endpoint * paginate get node dependencies * paginate get node dependencies * paginate node properties endpoint * paginate validation rules endpoint * paginate get projects endpoint * update schematic and other packages * remove uneeded type ignores * added generate manifest endpoints * temp commit * delete manifest file * add generate manifest endpoint * fix broken tests * ci(sage-monorepo): create a GH composite action to setup the dev container (#2438) * Create a composite action to setup the dev container * Add shell * Add shell * Fix indent * Add shell * Temporarily comment out sonar scan for pushes to main (#2443) * Touch one file (#2444) * Restore sonar scan in CI workflow (#2446) * Undo openchallenges-app touch (#2447) * Add name when running `.github/actions/setup-dev-container` (#2451) * ci(sage-monorepo): experiment with `pull_request_target` (#2453) * Add ssonar scan workflow * Check if secret can be read * ci(sage-monorepo): try sonar scan trigger (#2454) * Touch OC app file * Update workflow to run sonar scans * ci(sage-monorepo): test sonar scan from PR from fork (#2455) * Touch OC web app * Touch the file again * Fetch correct branch * Undo changes to web app * ci(sage-monorepo): try new sonar scan workflow for PRs (#2456) * Touch oc web app * Update sonar scan workflow * ci(sage-monorepo): try sonar scan workflow triggered by fork PR (#2457) * Touch OC web app * Trigger again the workflow * Create prototype of new sonar scanner for pr * Cleanup * Cleanup * Update scanner parameters * Disable sonar scanner in main CI workflow * ci(sage-monorepo): parametrize sonar scanner tool (#2458) * Touch oc web app * Ignore .nx * Save before trying Bard suggestion * Upgrade sonar scanner to support PR * Simplify command * Cleanpu * Set working dir * Specify PR number to SonarScanner for Gradle * Remove scanner tool proto * Sort Ci env vars in alphanum * Update message * ci(sage-monorepo): fix how env vars are passed to the dev container (#2459) * Touch two projects with scanner * Pass env var to CI * Add SONAR_PULL_REQUEST_NUMBER to dev container definition * ci(sage-monorepo): try sonar scan again for PRs originating from forks (#2460) * Touch two OC projects * Require label `sonar-scan-appproved` to run Sonar * Remove hard coded PR number * ci(sage-monorepo): test Sonar workflow with label-based approval (#2461) * Touch two oc projects * Throw error if sonar label is missing * Update mesage * Touch two oc projects (#2462) --------- Co-authored-by: Thomas Schaffter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2450
Description
The new sonar workflow created in the previous PR failed, so debugged and run the command locally:
Success! The scan report is properly associated to this PR on SonarCloud.
Proof that the PR is properly identified, the SonarCloud app just posted below the result of the scan to this PR thread. 👇 The app also added the check to the PR.
Update
The Sonar option
sonar.pullrequest.keyis enough to enable Sonar to identify the PR. The command can be simplified to:Update
This error is thrown by the above command IF
SONAR_TOKENis not defined.Insight
At most, there will be one report published by Sonar to a PR thread by project.