feat(schematic): replace molecularentity with patient #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewelamb
requested review from
GiaJordan,
linglp,
mialy-defelice and
milen-sage
as code owners
andrewelamb
changed the title
andrewelamb
added
the
sonar-scan-approved-deprecated
|
linglp
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Approve for now. My understanding is that we currently don't have classes in example data models that have properties. But I want to double check with @mialy-defelice on this. If we have classes in the example data model that could let this endpoint return something, I would recommend using those classes. If not, I think it is not a big deal to just return an empty list as example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schematic-api:testfails onmain#2463MolecularEntitynode has been removed form the test data model,a nd has been replaced withPatientin tests