Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schematic): update scheamtic and typing fixes #2472

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat(schematic): update scheamtic and typing fixes #2472

merged 1 commit into from
Jan 29, 2024

Conversation

andrewelamb
Copy link
Contributor

  • fixes fds-1661
  • Upgrades schematic to 23.12.1
  • Upgrades other packages minor versions
  • Incorporates typing fixes from 23.12.1
  • Removes typing.Union and typing.Optional for pipe notation Optional[str] -> str | None as is standard in python 3.10 or higher
  • Some docstring fixes

@andrewelamb andrewelamb changed the title fix typing (#2471) feat(schematic): update scheamtic and typing fixes Jan 29, 2024
@andrewelamb andrewelamb added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Jan 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'schematic-api'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrewelamb andrewelamb merged commit e853930 into main Jan 29, 2024
9 of 11 checks passed
@andrewelamb andrewelamb deleted the Schematic-API-Staging branch January 29, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linglp linglp linglp approved these changes

@GiaJordan GiaJordan Awaiting requested review from GiaJordan

@mialy-defelice mialy-defelice Awaiting requested review from mialy-defelice

@milen-sage milen-sage Awaiting requested review from milen-sage

Assignees
No one assigned
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewelamb @linglp