-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schematic): fix how schematic_api folder being copied in Dockerfile #2579
Conversation
@andrewelamb I would appreciate if both of you could take a look and try building docker container from your end. It should work as expected now. And @tschaffter, after you merge your PR: #2573, I could pull your PR and do another round of test. |
@linglp It's best if you pull the changes from |
Thanks Thomas. I did what you suggested. Could you test by building the container? |
@linglp Is there something specific that you would like me to test? The CI workflow already confirms that the image can be built successfully. |
If you don't mind, could you spin up the container by using |
The container keeps restarting on my end.
|
hmm @tschaffter , did you run
|
I didn't. I didn't pay attention to the error message but does it say exactly what the issue is (key/certificate missing)? Otherwise, it's OK to merge the PR if it's working on your end. |
So if I don't run the prepare certificate script, in the log I could see:
But the log is quite long.. you might have to scroll a little bit more to see the message. |
@linglp When I checked out this branch I got:
|
Changes
main.py
since the original__main__
could still work. I pointed uWSGI file to look at__main__.py
Test
I made sure that the docker image could be built successfully and the container could be run (and swagger UI page is showing). Also ensured that
nx build-image schematic-api
andnx serve-detach schematic-api
are working as expected.