Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openchallenges): fix OC EDAM ETL issues reported by Sonar #2594

Merged
merged 4 commits into from
Mar 25, 2024
Merged

fix(openchallenges): fix OC EDAM ETL issues reported by Sonar #2594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
380068b
add edam-etl to code quality dashboard
tschaffter Mar 23, 2024
8089c06
fix potential variable expansion issues
tschaffter Mar 23, 2024
e88c008
fix numpy import
tschaffter Mar 23, 2024
08c361c
Merge branch 'main' into fix-sonar-issues
tschaffter Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODE_QUALITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
| **OpenChallenges** ||
| [app](https://sonarcloud.io/summary/overall?id=openchallenges-app) | ![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-app&metric=alert_status) | ![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-app&metric=reliability_rating) | ![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-app&metric=sqale_rating) | ![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-app&metric=sqale_index) | ![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-app&metric=coverage) |
| [challenge-service](https://sonarcloud.io/summary/overall?id=openchallenges-challenge-service) | ![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-challenge-service&metric=alert_status) | ![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-challenge-service&metric=reliability_rating) | ![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-challenge-service&metric=sqale_rating) | ![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-challenge-service&metric=sqale_index) | ![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-challenge-service&metric=coverage) |
| [edam-etl](https://sonarcloud.io/summary/overall?id=openchallenges-edam-etl) | ![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-edam-etl&metric=alert_status) | ![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-edam-etl&metric=reliability_rating) | ![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-edam-etl&metric=sqale_rating) | ![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-edam-etl&metric=sqale_index) | ![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-edam-etl&metric=coverage) |
| [image-service](https://sonarcloud.io/summary/overall?id=openchallenges-image-service) | ![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-image-service&metric=alert_status) | ![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-image-service&metric=reliability_rating) | ![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-image-service&metric=sqale_rating) | ![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-image-service&metric=sqale_index) | ![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-image-service&metric=coverage) |
| [organization-service](https://sonarcloud.io/summary/overall?id=openchallenges-organization-service) | ![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-organization-service&metric=alert_status) | ![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-organization-service&metric=reliability_rating) | ![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-organization-service&metric=sqale_rating) | ![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-organization-service&metric=sqale_index) | ![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openchallenges-organization-service&metric=coverage) |
| **Schematic** ||
Expand Down
4 changes: 2 additions & 2 deletions apps/openchallenges/edam-etl/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ ARG USER_GID=$USER_UID
ENV APP_DIR=/opt/app \
APP_USERNAME=${USERNAME}

RUN groupadd --gid $USER_GID $USERNAME \
&& useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \
RUN groupadd --gid "$USER_GID" "$USERNAME" \
&& useradd --uid "$USER_UID" --gid "$USER_GID" -m "$USERNAME" \
# Install sudo
&& apt-get update -qq -y && export DEBIAN_FRONTEND=noninteractive \
&& apt-get install --no-install-recommends -qq -y \
Expand Down
1 change: 1 addition & 0 deletions apps/openchallenges/edam-etl/src/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import numpy as np
import pandas as pd
import requests
from os import getenv
Expand Down
Loading