New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agora): float download button and modal-link right (AG-1658), round buttons (AG-1701), fix icons, style dropdowns #3023

Merged

hallieswan merged 2 commits into Sage-Bionetworks:main from hallieswan:agora/AG-1658_AG-1701

Mar 1, 2025

Collaborator

hallieswan commented Feb 28, 2025 •

edited

Loading

Description

We recently transitioned to using PrimeNG to v19 and a preset theme, which broke some existing styling.

Related Issues

Changelog

Floats download button and modal-link to the right
Converts p-dropdown to p-select and updates styles accordingly
Updates p-select preset style to remove focus style to match current dev style
Makes dropdowns on gene RNA and protein evidence pages full width
Fixes font awesome icon imports
Rounds GCT buttons

Validation

page	change	current dev	new dev	fix
GCT help	font awesome icon
GCT	button shape, dropdown style
gene details	download and modal link alignment, button shape, radiobutton label alignment

GCT dropdown styling:

Current dev:

gct_dropdown_currentdev.mov

New dev:

gct_dropdown_newdev.mov

Fix:

gct_dropdown_fix.mov

hallieswan added 2 commits

February 28, 2025 21:58


          AG-1658: float download button and modal-link right, AG-1701: round b…

37e1e60

…uttons, fix fontawesome icons


          AG-1524: align dropdown styles

b887276

hallieswan requested a deployment to sonar

February 28, 2025 23:12

— with

GitHub Actions Waiting

hallieswan commented

View reviewed changes

apps/agora/app/src/app/myPrimeNGPreset.ts Show resolved Hide resolved

hallieswan commented

View reviewed changes

...omponents/gene-comparison-tool-how-to-panel/gene-comparison-tool-how-to-panel.component.html Show resolved Hide resolved

hallieswan requested a deployment to agora-pr

February 28, 2025 23:14

— with

GitHub Actions Waiting

hallieswan commented

View reviewed changes

libs/agora/gene-comparison-tool/src/lib/gene-comparison-tool.component.html Show resolved Hide resolved

hallieswan commented

View reviewed changes

libs/agora/gene-comparison-tool/src/lib/gene-comparison-tool.component.scss Show resolved Hide resolved

hallieswan commented

View reviewed changes

libs/agora/genes/src/lib/components/download-dom-image/download-dom-image.component.html Show resolved Hide resolved

hallieswan commented

View reviewed changes

libs/agora/genes/src/lib/components/download-dom-image/download-dom-image.component.scss Show resolved Hide resolved

hallieswan commented

View reviewed changes

libs/agora/genes/src/lib/components/gene-protein-selector/gene-protein-selector.component.html Show resolved Hide resolved

hallieswan commented

View reviewed changes

libs/agora/shared/src/lib/modal-link/modal-link.component.scss Show resolved Hide resolved

hallieswan marked this pull request as ready for review

February 28, 2025 23:20

hallieswan requested a review from a team as a code owner

February 28, 2025 23:21

sagely1 approved these changes

View reviewed changes

Contributor

sagely1 left a comment

LGTM!

hallieswan added this pull request to the merge queue

Merged via the queue into Sage-Bionetworks:main with commit 132a6d2

14 of 16 checks passed

hallieswan deleted the agora/AG-1658_AG-1701 branch

March 1, 2025 00:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet