[ALZ-179] Use CSV-based table insertion #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See this Sage-Bionetworks/synapser#334. We are currently working on a new release |
Fantastic. Thanks for the heads up. I'll keep this PR open as a possible workaround for the app in the meantime, but when the new release is ready we should be able to close this. CC @JessterB . |
|
Converting to draft as we wait for the fix on the backend CC @JessterB |
|
@JessterB i've verified the new release of synapser works (its only in staging right now), so we won't need this PR. code is here if for whatever reason we decide to come back to it, but ill close the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue appears to be a failure to import Pandas - because Pandas can't be imported, the dictionary representing the new row can't get imported either.
I believe this has something to do with numpy / pandas and the respective 2.0 variations - i think
synapseclientin Python depends on Pandas 2.0+, but Numpy 1.24.x... and there's an import failure.Fixing the above would be the ideal solution - but until then, if we create a temp CSV on disk with the row to be inserted, we can pass a string filepath to it, and the synapse$Table method handles it!