Merge pull request #1625 from jay-hodgson/standards-data

Hook up real standards MV and a dummy Standard Details page
Sage-Bionetworks · Mar 7, 2025 · 49c7c3a · 49c7c3a
2 parents d49bc36 + 3b85f72
commit 49c7c3a
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 58 deletions.
diff --git a/apps/portals/standards/src/config/resources.ts b/apps/portals/standards/src/config/resources.ts
@@ -1 +1 @@
-export const dataSql = `SELECT id, study, numberParticipants,reportedOutcome,dataCollectionMethod,deviceType,devicePlatform,deviceLocation,sensorType,diagnosis,digitalAssessmentCategory,digitalAssessmentDetails,dataType,dataSubtype,dataDescriptionLocation, dataAccessInstructions FROM syn21994970.10 where dhPortalIndex = 'TRUE'`
+export const dataSql = `SELECT * FROM syn64960277`
diff --git a/apps/portals/standards/src/config/synapseConfigs/data.ts b/apps/portals/standards/src/config/synapseConfigs/data.ts
@@ -10,18 +10,10 @@ import { dataSql } from '../resources'
 const dataRgbIndex = 0
 export const dataColumnLinks: LabelLinkConfig = [
   {
-    matchColumnName: 'dataDescriptionLocation',
-    isMarkdown: true,
-  },
-  {
-    matchColumnName: 'dataAccessInstructions',
-    isMarkdown: true,
-  },
-  {
-    matchColumnName: 'study',
+    matchColumnName: 'Name',
     isMarkdown: false,
-    baseURL: 'Explore/Collections/DetailsPage',
-    URLColumnName: 'study',
+    baseURL: 'Explore/Standard/DetailsPage',
+    URLColumnName: 'Name',
   },
 ]
 
@@ -30,34 +22,16 @@ export const dataQueryWrapperPlotNavProps: QueryWrapperPlotNavProps = {
   shouldDeepLink: true,
   hideDownload: true,
   sql: dataSql,
-  name: 'Data',
+  name: 'Standards',
   columnAliases,
   tableConfiguration: {
     showDownloadColumn: false,
     columnLinks: dataColumnLinks,
   },
   facetsToPlot: [
-    'study',
-    'reportedOutcome',
-    'dataCollectionMethod',
-    'deviceType',
-    'devicePlatform',
-    'deviceLocation',
-    'diagnosis',
-    'digitalAssessmentCategory',
-    'dataType',
-    'dataSubtype',
+    'Data_Topic',
+    // 'Organizations',
   ],
-  searchConfiguration: {
-    searchable: [
-      'collection',
-      'reportedOutcome',
-      'devicePlatform',
-      'diagnosis',
-      'digitalAssessmentCategory',
-      'digitalAssessmentDetails',
-    ],
-  },
   initialPlotType: 'BAR',
 }
 

diff --git a/apps/portals/standards/src/pages/StandardsDetailsPage.tsx b/apps/portals/standards/src/pages/StandardsDetailsPage.tsx
@@ -8,9 +8,20 @@ import { MarkdownSynapseFromColumnData } from '@sage-bionetworks/synapse-portal-
 import { useGetPortalComponentSearchParams } from '@sage-bionetworks/synapse-portal-framework/utils/UseGetPortalComponentSearchParams'
 import {
   ErrorPage,
+  GenericCardSchema,
+  SynapseConstants,
   SynapseErrorType,
 } from 'synapse-react-client'
 import { dataSql } from '../config/resources'
+import { CardContainerLogic } from 'synapse-react-client'
+
+export const standardsCardSchema: GenericCardSchema = {
+  type: SynapseConstants.GENERIC_CARD,
+  title: 'Name',
+  // subTitle: '',
+  // description: '',
+  secondaryLabels: ['Collections', 'Data_Topic', 'Organizations'],
+}
 
 export const standardDetailsPageContent: DetailsPageContentType = [
   {
@@ -41,42 +52,37 @@ export const standardDetailsPageContent: DetailsPageContentType = [
     title: 'Related Standards',
     element: (
       <DetailsPageContextConsumer columnName={'id'}>
-      {({ value }) => (
-        <>{value}</>
-        // TODO:
-        // <CardContainerLogic
-        //   {...standardCardContainerProps}
-        //   searchParams={{ standardId: value! }}
-        // />
-      )}
-    </DetailsPageContextConsumer>
-
+        {({ value }) => (
+          <>{value}</>
+          // TODO:
+          // <CardContainerLogic
+          //   {...standardCardContainerProps}
+          //   searchParams={{ standardId: value! }}
+          // />
+        )}
+      </DetailsPageContextConsumer>
     ),
   },
 ]
 
 export default function StandardsDetailsPage() {
-  const { study } = useGetPortalComponentSearchParams()
+  const { Name } = useGetPortalComponentSearchParams()
 
-  if (!study) {
+  if (!Name) {
     return <ErrorPage type={SynapseErrorType.NOT_FOUND} gotoPlace={() => {}} />
   }
   return (
     <>
       {/* TODO: header card */}
-      {/* <CardContainerLogic
-        isHeader
-        isAlignToLeftNav
-        {...standardsCardConfiguration}
-        columnAliases={columnAliases}
-        genericCardSchema={{
-          ...standardsSchema,
-          title: 'name',
-          link: 'id',
-        }}
-        sql={studySql}
-        searchParams={{ study }}
-      /> */}
+      <CardContainerLogic
+        sql={dataSql}
+        type={SynapseConstants.GENERIC_CARD}
+        genericCardSchema={standardsCardSchema}
+        secondaryLabelLimit={6}
+        isHeader={true}
+        searchParams={{ Name }}
+      />
+
       <DetailsPage sql={dataSql}>
         <DetailsPageContent content={standardDetailsPageContent} />
       </DetailsPage>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const dataSql = `SELECT id, study, numberParticipants,reportedOutcome,dataCollectionMethod,deviceType,devicePlatform,deviceLocation,sensorType,diagnosis,digitalAssessmentCategory,digitalAssessmentDetails,dataType,dataSubtype,dataDescriptionLocation, dataAccessInstructions FROM syn21994970.10 where dhPortalIndex = 'TRUE'`
		export const dataSql = `SELECT * FROM syn64960277`