Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWC-7257 #1594

Merged
merged 1 commit into from
Feb 25, 2025
Merged

SWC-7257 #1594

merged 1 commit into from
Feb 25, 2025

Conversation

jay-hodgson
Copy link
Member

Use a memoized version of the callback that only changes if onQueryResultBundleChange changes.

@jay-hodgson jay-hodgson requested a review from kianamcc February 25, 2025 00:32
kianamcc
kianamcc approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@kianamcc kianamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That should help keep onQueryResultBundleChange more stable

@jay-hodgson jay-hodgson merged commit 3e61d9b into Sage-Bionetworks:main Feb 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianamcc kianamcc kianamcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-hodgson @kianamcc