PORTALS-3385: [CCKP Homepage_V1] Add icons to CCKP cards for data types #1620
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-hodgson
reviewed
Mar 6, 2025
| const queryContext = useQueryContext() | ||
| const { addValueToSelectedFacet } = queryContext | ||
|
|
||
| const handleIconClick = (dataType: 'string') => { |
There was a problem hiding this comment.
Function is recreated on rerender (I think). Is this a good place for a useCallback? (It's unclear to me if IconSvg is going to be re-rendered when this is recreated)
jay-hodgson
reviewed
Mar 6, 2025
| const facet: UniqueFacetIdentifier = { | ||
| columnName: 'dataType', | ||
| } | ||
| addValueToSelectedFacet(facet, dataType) |
There was a problem hiding this comment.
I verified that addValueToSelectedFacet in TableQueryReducerActions handles the case when the caller attempts to add the same facet value more than once (duplicate value is not pushed). So this should be fine!
jay-hodgson
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://sagebionetworks.jira.com/browse/PORTALS-3385?atlOrigin=eyJpIjoiNDVlMmNiODdkZmU0NGVkZGFiYmMwNmFiNzhiOTY1YjgiLCJwIjoiaiJ9
IconList:
Created a handleIconClick function to implement this functionality.
Will create a PORTALS-3385-V2 branch to add this feature to CCKP when data is available and add a link to that PR in the ticket.